Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(r): Support native creation of more numeric Arrow arrays from integer vectors #697

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Dec 27, 2024

Before we had been punting to the arrow R package for this which wasn't necessary! This was exposed by a test that had been added for matrix support that wasn't skipped if arrow wasn't installed.

library(nanoarrow)
as_nanoarrow_array(1:10, schema = na_double())
#> <nanoarrow_array double[10]>
#>  $ length    : int 10
#>  $ null_count: int 0
#>  $ offset    : int 0
#>  $ buffers   :List of 2
#>   ..$ :<nanoarrow_buffer validity<bool>[null] ``
#>   ..$ :<nanoarrow_buffer data<double>[10][80 b]> `1 2 3 4 5 6 7 8 9 10`
#>  $ dictionary: NULL
#>  $ children  : list()

Created on 2024-12-26 with reprex v2.1.1

@paleolimbot paleolimbot changed the title feat(r): Support native creation of numeric Arrow arrays from integer vectors feat(r): Support native creation of more numeric Arrow arrays from integer vectors Dec 27, 2024
@paleolimbot paleolimbot requested a review from amoeba December 27, 2024 04:09
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, no notes.

@paleolimbot
Copy link
Member Author

Thank you for the review!

@paleolimbot paleolimbot merged commit 18652fc into apache:main Dec 30, 2024
12 checks passed
@paleolimbot paleolimbot deleted the r-int-convert branch January 9, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants