Implement ViewBinaryViewArrayAsBytes #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
force-pushed
the
asbytes-view-iterator
branch
from
9e3d004 to
bbcea42
Compare
paleolimbot
approved these changes
Jan 30, 2025
| EXPECT_EQ(slot, expected[i]); | ||
| } | ||
| ++i; | ||
| } |
There was a problem hiding this comment.
Should you increment the offset here and test again to make sure the offset is applied correctly? (I'm always paranoid that something isn't taking into account an offset 🙂 )
There was a problem hiding this comment.
Nice idea - added some parametrization for that
| @@ -234,6 +234,60 @@ class ViewArrayAsBytes { | |||
| value_type operator[](int64_t i) const { return range_.get(i); } | |||
| }; | |||
|
|
|||
| class ViewBinaryViewArrayAsBytes { | |||
There was a problem hiding this comment.
Should this be ViewBinaryArray*View*AsBytes?
There was a problem hiding this comment.
I don't think so (?) Following the pattern of the other classes, they are all ArrayAs... even though they accept an array view in the constructor
paleolimbot
approved these changes
Jan 30, 2025
|
Thanks @paleolimbot for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633