Convert prettyprint tests in arrow-cast to insta inline snapshots#9472
Open
grtlr wants to merge 3 commits intoapache:mainfrom
Open
Convert prettyprint tests in arrow-cast to insta inline snapshots#9472grtlr wants to merge 3 commits intoapache:mainfrom
prettyprint tests in arrow-cast to insta inline snapshots#9472grtlr wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The motivation for this PR is to create to improve the testing infrastructure as a precursor to the following PR:
quoted_stringstoFormatOptions#9221@Jefffrey seemed to be in favor of using
instafor more tests: #9221 (comment)What changes are included in this PR?
This PR does not do logic changes, but is a straightforward translation of the current tests. More test cases, especially around escape sequences can be added in follow up PRs.
Are these changes tested?
Yes, to review we still need to manually confirm that no test cases changed accidentally.
Are there any user-facing changes?
No.