[Integration][Archery] Remove skips for nanoarrow IPC compression ZSTD/uncompressible golden files #45204
Comments
paleolimbot
added a commit
that referenced
this issue
Jan 10, 2025
…ession ZSTD/uncompressible golden files (#45205) ### Rationale for this change After apache/arrow-nanoarrow#693 , ZSTD compression is now supported in the nanoarrow IPC reader. The list of skips lives in archery, though, and I'd like those checks to run (here and on our own CI!). ### What changes are included in this PR? The line skipping compression checks for nanoarrow IPC were modified to only skip lz4 (which is not yet implemented). ### Are these changes tested? Yes, this code runs as part of the integration CI job. The skipped tester is not run in the Arrow repo, though (because of the "target implementations", which correctly doesn't include nanoarrow here); however, the changes are tested in apache/arrow-nanoarrow#704 . (That PR will need to merge before this one because this PR updates the nanoarrow build script in a way will cause the integration job to fail before that PR is merged) ### Are there any user-facing changes? No! * GitHub Issue: #45204 Lead-authored-by: Dewey Dunnington <[email protected]> Co-authored-by: Dewey Dunnington <[email protected]> Signed-off-by: Dewey Dunnington <[email protected]>
|
Issue resolved by pull request 45205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
After apache/arrow-nanoarrow#693 , ZSTD compression is now supported in the nanoarrow IPC reader. The list of skips lives in archery, though, and I'd like those checks to run (here and on our own CI!).
Component(s)
Archery, Integration
The text was updated successfully, but these errors were encountered: