GH-45204: [Integration][Archery] Remove skips for nanoarrow IPC compression ZSTD/uncompressible golden files #45205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paleolimbot
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Jan 9, 2025
…#704) This PR updates the CMake such that it works in conda after a `conda install zstd` (which doesn't provide `libzstd_static`, but does provide `libzstd`). This is needed to unskip the integration tests for zstd because the integration image uses conda ( apache/arrow#45205 ). Previous commits tested apache/arrow#45205 by specifically pulling that branch instead of apache/arrow. When zstd is installed...the tests pass!
paleolimbot
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 913cb58. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 19 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After apache/arrow-nanoarrow#693 , ZSTD compression is now supported in the nanoarrow IPC reader. The list of skips lives in archery, though, and I'd like those checks to run (here and on our own CI!).
What changes are included in this PR?
The line skipping compression checks for nanoarrow IPC were modified to only skip lz4 (which is not yet implemented).
Are these changes tested?
Yes, this code runs as part of the integration CI job. The skipped tester is not run in the Arrow repo, though (because of the "target implementations", which correctly doesn't include nanoarrow here); however, the changes are tested in apache/arrow-nanoarrow#704 .
(That PR will need to merge before this one because this PR updates the nanoarrow build script in a way will cause the integration job to fail before that PR is merged)
Are there any user-facing changes?
No!