[CALCITE-6819] MSSQL doesn't support TRUE/FALSE keywords in its Join predicate #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…predicate In MSSQL dialect use 1=1 instead of TRUE
NobiGo
reviewed
Feb 13, 2025
core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
Show resolved
Hide resolved
…predicate PR comments
NobiGo
reviewed
Feb 14, 2025
| @@ -196,4 +197,12 @@ public static SqlSpecialOperator specialOperatorByName(String opName) { | |||
| } | |||
| }; | |||
| } | |||
|
|
|||
| public static void writeAlwaysCondition(SqlWriter writer, boolean value) { | |||
There was a problem hiding this comment.
This method requires some annotations to clarify that some databases require converting True to '1=1' and false to '1=0'.
| writer.sep(SqlStdOperatorTable.EQUALS.getName()); | ||
| writer.literal(value ? "1" : "0"); | ||
| writer.endList(frame); | ||
| writeAlwaysCondition(writer, value); |
There was a problem hiding this comment.
unparseBoolLiteralToCondition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSSQL dialect use 1=1 instead of TRUE