Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21716: Improve JBang Kubernetes plugin container image options #17061

Conversation

christophd
Copy link
Contributor

Description

  • Set basic settings on JIB image builder
  • Introduce configurable base image (default is still eclipse-temurin:17)
  • Set image platforms on JKube properties
  • Set proper image push registry on JKube properties

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Fixes CAMEL-21716

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@davsclaus davsclaus force-pushed the chore/improve-jbang-kubernetes-run-image-options branch from 61a94a1 to 4c03397 Compare February 5, 2025 08:45
- Set basic settings on JIB image builder
- Introduce configurable base image (default is still eclipse-temurin:17)
- Set image platforms on JKube properties
- Set proper image push registry on JKube properties
@davsclaus davsclaus force-pushed the chore/improve-jbang-kubernetes-run-image-options branch from 4c03397 to cf627a7 Compare February 5, 2025 09:38
@davsclaus davsclaus merged commit 3911280 into apache:main Feb 5, 2025
4 checks passed
@claudio4j
Copy link
Contributor

I see the jkube.base.image is not a real jkube property from the jkube k8s page, it seems a wrapper for jkube.container-image.from, so perhaps why not set the jkube.container-image.from from --base-image ?

I had exported with --base-image=registry.redhat.io/quarkus/mandrel-for-jdk-21-rhel8:23.1 --registry-mirror=mirror.gcr.io it generated the following property, maybe there should be some validation for them.

<jkube.base.image>mirror.gcr.io/registry.redhat.io/quarkus/mandrel-for-jdk-21-rhel8:23.1

@christophd
Copy link
Contributor Author

@claudio4j thanks, these are valid improvement suggestions. please feel free to work on these items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants