CASSANDRA-20156: To improve accord interoperability test coverage, need to extend the harry model domain to handle more possible CQL states #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweisberg
approved these changes
Feb 3, 2025
| * This test exists to help isolate issues with {@link SingleNodeTableWalkTest} and related classes. | ||
| */ | ||
| @Ignore | ||
| public class RepoTest extends TestBaseImpl |
There was a problem hiding this comment.
I don't see this on cep-15-accord is it temporary?
| } | ||
| else if (ctx.eq.keySet().containsAll(factory.partitionColumns)) | ||
| { | ||
| // tested |
There was a problem hiding this comment.
Are these comments supposed to stay? Are they just tracking what you already wrote tests for?
| { | ||
| validate(actual, results.rows); | ||
| throw new AssertionError("Unexpected results for query: " + StringUtils.escapeControlChars(select.visit(StandardVisitors.DEBUG).toCQL()), e); |
There was a problem hiding this comment.
Should this use the visitor in StatefulASTBase?
| @@ -534,7 +534,7 @@ public boolean allowNonPartitionMultiColumnQuery() | |||
|
|
|||
| private List<Symbol> multiColumnQueryColumns() | |||
| { | |||
| List<Symbol> allowedColumns = model.factory.selectionOrder; | |||
| List<Symbol> allowedColumns = searchableColumns; | |||
There was a problem hiding this comment.
I don't quite understand why the number of columns in the partition key determines the usage of selectionOrder vs nonPartitionColumns. selectionOrder is all columns and nonPartitionColumns I assume the non-pkey columns.
dcapwell
force-pushed
the
CASSANDRA-20156_trunk
branch
from
4dc411b to
95cf28b
Compare
…history on single node
…now show actual as well
…lude partitions with only static rows
…lustering column search happened... regression after unifying search with include
…to static column deletetion
…ally need to make the select/assert logic cleaner
…stream collection, and added a new withTimestamp to add timestamps after the fact
dcapwell
force-pushed
the
CASSANDRA-20156_trunk
branch
from
8f893ca to
08da2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.