Improve reliability of Accord tests that count messages #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that rely on message counting are having trouble with Accord system initiated transactions getting counted instead of what is being tested for. Add a filter to exclude those messages so that only messages from the test transactions are included. Patch by Ariel Weisberg; Reviewed by David Capwell for CASSANDRA-20277
belliottsmith
force-pushed
the
cep-15-accord
branch
2 times, most recently
from
fee0e64 to
a3a37f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that rely on message counting are having trouble with Accord system initiated transactions getting counted instead of what is being tested for. Add a filter to exclude those messages so that only messages from the test transactions are included.
Patch by Ariel Weisberg; Reviewed by David Capwell for CASSANDRA-20277