Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Comments section with Use cases #467

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jan 7, 2025

@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 7, 2025

@blueorangutan docbuild

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/467. (QA-JID 297)

Copy link
Contributor

@NuxRo NuxRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we need to clarify that users and admins can only add comments to objects they have the privileges to access!
  • some comments can be "admin-only", do we need to also think about what the domain admins can read/write, should a similar capability be extended to them?

@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 8, 2025

@blueorangutan docbuild

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/467. (QA-JID 298)

@DaanHoogland
Copy link
Contributor

@nvazquez , this is how it is intended, isn't it? not how it works atm!

@nvazquez
Copy link
Contributor Author

@DaanHoogland yes, but mostly its how its working besides the bug found, I'll add some additional notes or warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants