Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vTPM: add vm settings #490

Draft
wants to merge 5 commits into
base: 4.20.0.0-base
Choose a base branch
from

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Mar 17, 2025

@weizhouapache
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/490. (QA-JID 312)

@weizhouapache
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/490. (QA-JID 313)

@rohityadavcloud
Copy link
Member

LGTM - but should this be on 4.20 branch @weizhouapache ?

@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone Mar 17, 2025
@weizhouapache
Copy link
Member Author

LGTM - but should this be on 4.20 branch @weizhouapache ?

thanks @rohityadavcloud

4.20.0.0-base was created by @Pearl1594. I assume it is the branch for 4.20.1.0 release, right ? @Pearl1594

@rohityadavcloud
Copy link
Member

Historically, we have not created .minor release branches, but shipped minor release's docs from the major release branch. I don't see why 4.20.1.0 could be a tag on the 4.20 doc repo branch and be used to ship the docs for 4.20.1.0 release.

@weizhouapache
Copy link
Member Author

Historically, we have not created .minor release branches, but shipped minor release's docs from the major release branch. I don't see why 4.20.1.0 could be a tag on the 4.20 doc repo branch and be used to ship the docs for 4.20.1.0 release.

maybe we need to create a 4.20 branch for 4.20.x releases, similar to what we are doing with apache/cloudstack repo.

some doc PRs have been merged into main branch, as the features are merged into apache/cloudstack main branch. for example
#461 (Doc PR for apache/cloudstack#10017)
#476 (Doc PR for apache/cloudstack#10300)

these changes should not be released in 4.20.1.0

but there are also some doc PRs in main branch which are small fixes, which can be released in 4.20.1.0
may need to review the commits one by one . cc @rohityadavcloud @Pearl1594

@weizhouapache
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/490. (QA-JID 314)

@weizhouapache
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/490. (QA-JID 315)

@weizhouapache
Copy link
Member Author

@blueorangutan docbuild

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/490. (QA-JID 316)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants