-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix pod retrieval during volume attach #10324
base: 4.19
Are you sure you want to change the base?
Conversation
Fixes issue highlighted in apache#9315 (comment) Signed-off-by: Abhishek Kumar <[email protected]>
@blueorangutan package |
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10324 +/- ##
============================================
+ Coverage 4.29% 15.16% +10.86%
- Complexity 0 11314 +11314
============================================
Files 366 5409 +5043
Lines 29602 474474 +444872
Branches 5193 57877 +52684
============================================
+ Hits 1272 71944 +70672
- Misses 28185 394487 +366302
- Partials 145 8043 +7898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@shwstppr
thanks for the quick fix
@blueorangutan test |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-12306)
|
Signed-off-by: Abhishek Kumar <[email protected]>
@blueorangutan package |
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, let's test ;)
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12339 |
@DaanHoogland this is ready now. If we revert #10267 then I'll add commits from that here |
@blueorangutan test |
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
Fixes issue highlighted in #9315 (comment)
A volume in Allocated state can be attached to a stopped VM even when the actual volume is not created in the primary store.
test_12_start_vm_multiple_volumes_allocated
in test/integration/smoke/test_vm_life_cycle.py does the same.After changes in #10267, a scenario was failing as a suitable pool was not found for an allocated volume when attached to a VM which has never been started
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Verified test_vm_life_cycle.py with changes,
How did you try to break this feature and the system with this change?