Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Bump CordovaLib requirements to iOS 13+ #1480

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 27, 2024

Platforms affected

iOS

Motivation and Context

We already bumped the app template to a minimum of iOS 13 to support UISceneDelegates, and it turns out iOS 13 is the first version where WKURLSchemeTask is properly thread-safe, so we might as well bump CordovaLib and silence that warning that people keep complaining about 🥲

Description

Bump the minimum iOS target for CordovaLib to 13.0, and update tests/project files to match.

Closes #1427.

Testing

All existing tests pass, no warnings in Xcode.

Checklist

  • I've run the tests to see all new and existing tests pass

@dpogue dpogue added this to the 8.0.0 milestone Aug 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (458f5f3) to head (58afe74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          16       16           
  Lines        1871     1871           
=======================================
  Hits         1501     1501           
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue dpogue merged commit b6ae567 into apache:master Aug 29, 2024
10 checks passed
@dpogue dpogue deleted the lib-ios13 branch August 29, 2024 02:17
alena-n pushed a commit to alena-n/cordova-ios that referenced this pull request Nov 7, 2024
alena-n pushed a commit to alena-n/cordova-ios that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants