Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat!: SPM support #196

Closed
wants to merge 2 commits into from
Closed

WIP feat!: SPM support #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
336f79d
WIP: SPM support
jcesarmobile Apr 27, 2024
4606676
remove dependency
jcesarmobile Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
// swift-tools-version:5.5

/*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
*/

import PackageDescription

let package = Package(
name: "cordova-plugin-device",
platforms: [.iOS(.v11)],
products: [
.library(
name: "cordova-plugin-device",
targets: ["cordova-plugin-device"])
],
dependencies: [
.package(url: "https://github.com/apache/cordova-ios.git", branch: "master")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially be an issue since we can't distribute stuff pointing to the development branch, and it's probably bad if this doesn't match the version of CordovaLib being used in the app.

I guess SwiftPM has no concept of anything like "peer dependencies"? 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it since by keeping CordovaLib in the app project, having the dependency is not needed.

We will miss having plugins that are "standalone" so the source code can be built with xcodebuild without adding them to an app, but that is not possible at the moment neither, so not a big miss.

],
targets: [
.target(
name: "cordova-plugin-device",
dependencies: [
.product(name: "CordovaLib", package: "cordova-ios")
],
path: "src/",
sources: ["ios"],
publicHeadersPath: "ios"
)
]
)
3 changes: 0 additions & 3 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@
</feature>
</config-file>

<header-file src="src/ios/CDVDevice.h" />
<source-file src="src/ios/CDVDevice.m" />

<resource-file src="src/ios/CDVDevice.bundle" target="CDVDevice.bundle" />
</platform>

Expand Down
Loading