Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Regression breaking resolved DOM-usable file:// paths #640

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Regression from 99ca439

Code strips out the file:// protocol for what used to be used by File APIs, but in 8.1.1 that was changed to use CordvaResourceApi which expects an actual valid URI.

Description

If the uri object has no scheme set, then set it to the file scheme.

Testing

paramedic tests passes.
Testing by using camera plugin to capture an image, resolve the file:// uri and attempt to set an image tag src attribute to the fileEntry.toURL() result.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek requested a review from erisu October 25, 2024 13:58
@breautek breautek merged commit 0150006 into apache:master Oct 25, 2024
11 of 15 checks passed
@breautek breautek deleted the fix/regression branch October 25, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants