Move the keywords module

[koushiro]

Signed-off-by: koushiro [email protected]

[coveralls]

Pull Request Test Coverage Report for Build 1275068126

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 90.206%

---

Totals
Change from base Build 1273541769:	0.0%
Covered Lines:	5821
Relevant Lines:	6453

---

💛 - Coveralls

[koushiro]

/cc @alamb @Dandandan

[alamb]

So something that would help me understand these PRs is the rationale for making the change. For example, this PR perhaps makes the code structure a bit more logical but won't it require a bunch of rework for all users of the library?

[koushiro]

this PR perhaps makes the code structure a bit more logical but won't it require a bunch of rework for all users of the library?

yes

[houqp]

perhaps we can reexport the keywords module in dialect module to make it backwards compatible until we do the next major release?

[koushiro]

perhaps we can reexport the keywords module in dialect module to make it backwards compatible until we do the next major release?

@alamb has been released v0.11

[alamb]

I guess I am just thinking of users of this crate -- when they upgrade to a new version of sqlparser I feel the best experience is to minimize the amount of changes they have to make to their code.

For changes required to support new features (e.g. new enum variants or new fields in existing variants) I don't see a way around requiring the user code to change.

However, I don't like the idea of causing work for downstream users for changes that are basically internal improvements to sqlparser-rs

Thus, I would be happy to merge this PR if it was backwards compatible (and @houqp has suggested a good way to do that)

[koushiro]

@alamb Now the change is backwards compatible, I originally planned to add deprecated to re-export, like below:

#[deprecated(
    since = "0.11.1",
    note = "The keywords module has been moved into the root of the library, \
    please use sqlparser::keywords instead of sqlparser::dialect::keywords"
)]
pub use crate::keywords;

but it doesn't seem to work, see rust-lang/rust#30827

[alamb]

Thanks @koushiro !

[coveralls]

Pull Request Test Coverage Report for Build 1272354313

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 90.206%

---

Totals
Change from base Build 1270918470:	0.0%
Covered Lines:	5821
Relevant Lines:	6453

---

💛 - Coveralls