Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_unixtime does not support timestamps with a timezone #14490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

to_unixtime does not support timestamps with a timezone #14490

wants to merge 2 commits into from
+15 −1

Conversation

Omega359
Copy link
Contributor

@Omega359 Omega359 commented Feb 4, 2025

Which issue does this PR close?

Closes #14488

Rationale for this change

Fix functionality gap.

What changes are included in this PR?

Code, slt test.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions labels Feb 4, 2025
@Omega359 Omega359 marked this pull request as ready for review February 4, 2025 19:54
alamb
alamb approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @Omega359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
functions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_unixtime does not support timestamps with a timezone
2 participants
@Omega359 @alamb