Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Arrow Flight SQL ports as container ports in BEs and FEs #294 #295

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

jonasbrami
Copy link

What problem does this PR solve?

Issue Number: close #294

Problem Summary:
Expose Arrow Flight SQL ports as container ports in BEs and FEs pods #294

Release note

None

Check List (For Author)

  • Test

    • Tested locally in Minikube
  • Behavior changed:

    • No. Just aesthetics exposing the ports on the pod.
  • Does this need documentation?
    No.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@intelligentfu8
Copy link
Contributor

Arrow flight ports exposed in the container was supported. the PR that you submit is effective in disaggregated cluster. I will check the DorisCluster to confirm whether the ports are exposed or not in the container. The PR will approved until the disaggregated is considered to expose the ports.

pkg/common/utils/resource/service.go Outdated Show resolved Hide resolved
pkg/common/utils/resource/service.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hechao-ustc hechao-ustc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelligentfu8 intelligentfu8 merged commit 37f4926 into apache:master Dec 3, 2024
1 check passed
@catpineapple catpineapple mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Expose Arrow Flight SQL ports as container ports in BEs and FEs
3 participants