Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](example)add ddc example #313

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[improve](example)add ddc example #313

merged 1 commit into from
Dec 16, 2024

Conversation

catpineapple
Copy link
Contributor

@catpineapple catpineapple commented Dec 16, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

intelligentfu8
intelligentfu8 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelligentfu8 intelligentfu8 merged commit de1ceb2 into apache:master Dec 16, 2024
1 check passed
@catpineapple catpineapple mentioned this pull request Dec 20, 2024
Closed
@catpineapple catpineapple deleted the add-ddc-example branch January 24, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelligentfu8 intelligentfu8 intelligentfu8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catpineapple @intelligentfu8