Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor][fix](ddc)refactor clear resource code,fix service label error,use sts replicas… #318

Merged
merged 3 commits into from
Dec 19, 2024
Merged

[Refactor][fix](ddc)refactor clear resource code,fix service label error,use sts replicas… #318

merged 3 commits into from
Dec 19, 2024

Conversation

intelligentfu8
Copy link
Contributor

What problem does this PR solve?

  1. refactor the clear resource logic.
  2. fixed the service label error.
  3. use statefulset replicas to replace compute group's replica as the baseline for clear pvc.
  4. clear the unused codes for tiding.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
      1. deploy multi compute groups.
      2. reduce the first compute group replicas and delete second comute group.
      3. verify the svc , sts , PVC are equal to the final state.
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@intelligentfu8 intelligentfu8 changed the title refactor clear resource code,fix service label error,use sts replicas… [Refactor]refactor clear resource code,fix service label error,use sts replicas… Dec 18, 2024
catpineapple
catpineapple approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@catpineapple catpineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catpineapple catpineapple merged commit 5ef8f61 into apache:master Dec 19, 2024
1 check passed
@catpineapple catpineapple changed the title [Refactor]refactor clear resource code,fix service label error,use sts replicas… [Refactor][fix](ddc)refactor clear resource code,fix service label error,use sts replicas… Dec 20, 2024
@catpineapple catpineapple mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catpineapple catpineapple catpineapple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intelligentfu8 @catpineapple