Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prepareStatefulsetApply #323

Closed

Conversation

diannaowa
Copy link

@diannaowa diannaowa commented Jan 10, 2025

What problem does this PR solve?

fix make build error
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
prepareStatefulsetApply is missing parameters 'ctx'.
pkg/controller/sub_controller/be/controller.go:93:48: too many arguments in call to be.prepareStatefulsetApply

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@catpineapple
Copy link
Contributor

Hello, thank you for your attention to this open source project. However, as far as this fix is ​​concerned, the unreferenced function input should not be added. This problem has been solved here #326 . You are welcome to review this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants