Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve](load) improve error message "unknown load_id" #47509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 5, 2025

What problem does this PR solve?

Issue Number: DORIS-18129

Problem Summary:

  1. Remove stack trace when "unknown load_id".
  2. Suggest user to retry the load when this error occurs.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Contributor Author

kaijchen commented Feb 5, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32472 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

------ Round 1 ----------------------------------
q1	17615	5565	5406	5406
q2	2052	310	172	172
q3	10426	1288	725	725
q4	10219	971	534	534
q5	7526	2439	2174	2174
q6	198	172	136	136
q7	910	753	612	612
q8	9233	1386	1158	1158
q9	5244	4958	4943	4943
q10	6846	2328	1889	1889
q11	483	276	272	272
q12	344	360	215	215
q13	17758	3704	3158	3158
q14	222	233	215	215
q15	537	477	460	460
q16	632	613	587	587
q17	578	873	323	323
q18	7017	6577	6436	6436
q19	1209	967	552	552
q20	308	329	201	201
q21	2837	2246	1994	1994
q22	370	340	310	310
Total cold run time: 102564 ms
Total hot run time: 32472 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5917	5525	5512	5512
q2	242	332	232	232
q3	2259	2633	2297	2297
q4	1404	1833	1407	1407
q5	4308	4715	4666	4666
q6	174	164	127	127
q7	2087	2005	1869	1869
q8	2688	2810	2667	2667
q9	7457	7249	7205	7205
q10	2959	3288	2769	2769
q11	599	530	510	510
q12	678	770	646	646
q13	3501	3937	3316	3316
q14	276	317	271	271
q15	532	483	465	465
q16	664	680	655	655
q17	1227	1744	1255	1255
q18	7776	7488	7280	7280
q19	858	1177	1047	1047
q20	2002	2031	1895	1895
q21	5735	5264	4934	4934
q22	608	583	565	565
Total cold run time: 53951 ms
Total hot run time: 51590 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184428 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

query1	973	397	385	385
query2	6520	2113	2053	2053
query3	6795	220	222	220
query4	33303	23225	22972	22972
query5	4365	635	470	470
query6	312	199	188	188
query7	4605	485	310	310
query8	309	250	236	236
query9	9474	2656	2655	2655
query10	475	314	253	253
query11	18068	15091	14999	14999
query12	158	111	106	106
query13	1647	523	388	388
query14	10728	6504	7540	6504
query15	214	196	184	184
query16	7697	600	456	456
query17	1603	730	548	548
query18	1935	398	290	290
query19	216	185	169	169
query20	113	109	108	108
query21	210	123	101	101
query22	4237	4291	4014	4014
query23	33764	32848	33011	32848
query24	6410	2231	2270	2231
query25	497	440	383	383
query26	1202	271	150	150
query27	2000	464	325	325
query28	5133	2460	2419	2419
query29	658	562	416	416
query30	229	198	156	156
query31	932	879	794	794
query32	74	69	58	58
query33	513	355	298	298
query34	758	861	524	524
query35	778	802	733	733
query36	1008	1005	924	924
query37	120	104	80	80
query38	4320	4338	4143	4143
query39	1469	1450	1404	1404
query40	218	114	105	105
query41	61	56	60	56
query42	123	110	107	107
query43	517	535	512	512
query44	1323	825	810	810
query45	187	175	171	171
query46	857	1046	638	638
query47	1799	1860	1755	1755
query48	397	419	320	320
query49	813	511	443	443
query50	634	664	407	407
query51	4200	4202	4116	4116
query52	110	104	95	95
query53	232	260	183	183
query54	488	509	413	413
query55	83	78	82	78
query56	263	265	245	245
query57	1149	1146	1080	1080
query58	251	235	241	235
query59	3003	3067	2882	2882
query60	271	270	282	270
query61	123	122	123	122
query62	818	703	638	638
query63	216	194	187	187
query64	4160	1064	663	663
query65	3242	3163	3127	3127
query66	1044	415	312	312
query67	15938	15636	15413	15413
query68	2459	834	554	554
query69	408	296	265	265
query70	1219	1144	1149	1144
query71	323	299	259	259
query72	6032	3897	4177	3897
query73	638	745	360	360
query74	9591	8974	8830	8830
query75	3147	3154	2681	2681
query76	2228	1181	800	800
query77	334	369	282	282
query78	10038	10043	9402	9402
query79	986	894	603	603
query80	1217	551	446	446
query81	530	274	248	248
query82	1177	155	132	132
query83	284	182	160	160
query84	232	102	76	76
query85	840	381	304	304
query86	423	321	314	314
query87	4497	4481	4367	4367
query88	3130	2208	2152	2152
query89	398	335	292	292
query90	1714	196	198	196
query91	138	139	108	108
query92	60	58	54	54
query93	945	894	531	531
query94	617	408	311	311
query95	346	264	252	252
query96	502	624	284	284
query97	2777	2851	2788	2788
query98	221	218	201	201
query99	1317	1481	1257	1257
Total cold run time: 275110 ms
Total hot run time: 184428 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.61	0.11	0.11
query5	0.42	0.42	0.42
query6	1.13	0.67	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.60	0.50	0.49
query10	0.57	0.55	0.55
query11	0.16	0.09	0.10
query12	0.15	0.11	0.12
query13	0.62	0.62	0.61
query14	2.72	2.75	2.75
query15	0.92	0.82	0.82
query16	0.38	0.40	0.36
query17	1.01	1.07	1.07
query18	0.23	0.21	0.21
query19	1.97	1.87	1.98
query20	0.02	0.01	0.02
query21	15.36	0.95	0.58
query22	0.76	0.73	0.72
query23	15.31	1.45	0.59
query24	3.01	2.08	0.98
query25	0.22	0.18	0.06
query26	0.22	0.16	0.13
query27	0.06	0.06	0.04
query28	14.34	1.01	0.44
query29	12.60	3.99	3.30
query30	0.26	0.09	0.06
query31	2.82	0.61	0.39
query32	3.23	0.55	0.46
query33	3.02	3.01	3.06
query34	16.81	5.17	4.59
query35	4.58	4.58	4.54
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.65 s
Total hot run time: 30.98 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.09% (11004/26142)
Line Coverage: 32.37% (92901/287031)
Region Coverage: 31.51% (47627/151142)
Branch Coverage: 27.54% (24105/87534)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a8b4656812075065621d01b630c84be3c3017cb5_a8b4656812075065621d01b630c84be3c3017cb5/report/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants