Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](nereids) fix compare ipv4 / ipv6 always equals #47513

Merged

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Feb 5, 2025

What problem does this PR solve?

fix compare ipv4 and ipv6 always equals.

for example, select cast('127.0.0.1' as ipv4) = cast('192.168.10.10' as ipv4)' will return 1, but it should return 0;

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yujun777 yujun777 requested a review from dataroaring as a code owner February 5, 2025 08:55
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Collaborator Author

yujun777 commented Feb 5, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

PR approved by anyone and no changes requested.

@yujun777
Copy link
Collaborator Author

yujun777 commented Feb 6, 2025

run cloud_p0

@yujun777
Copy link
Collaborator Author

yujun777 commented Feb 6, 2025

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 40926 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6e016f8ce51d5ae945e9a5c8808f4fb763537f3d, data reload: false

------ Round 1 ----------------------------------
q1	17602	7329	7195	7195
q2	2047	174	169	169
q3	10755	1058	1149	1058
q4	10523	709	717	709
q5	7765	2880	2823	2823
q6	232	145	145	145
q7	968	609	594	594
q8	9348	1918	2010	1918
q9	6572	6395	6460	6395
q10	7021	2303	2334	2303
q11	469	274	263	263
q12	417	216	209	209
q13	17798	2974	2993	2974
q14	238	212	210	210
q15	566	536	534	534
q16	660	609	598	598
q17	974	590	544	544
q18	7132	6793	6749	6749
q19	1453	1076	1013	1013
q20	473	203	200	200
q21	4202	3446	3311	3311
q22	1120	1035	1012	1012
Total cold run time: 108335 ms
Total hot run time: 40926 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7245	7196	7189	7189
q2	341	236	235	235
q3	2941	2897	2960	2897
q4	2069	1802	1816	1802
q5	5706	5689	5674	5674
q6	221	140	138	138
q7	2215	1815	1849	1815
q8	3341	3580	3521	3521
q9	8819	8870	8750	8750
q10	3606	3539	3556	3539
q11	590	533	496	496
q12	799	611	603	603
q13	9421	3152	3136	3136
q14	307	269	278	269
q15	561	521	533	521
q16	691	638	662	638
q17	1812	1572	1590	1572
q18	8164	7663	7562	7562
q19	1656	1516	1652	1516
q20	2118	1862	1865	1862
q21	5524	5294	5424	5294
q22	1203	1062	1066	1062
Total cold run time: 69350 ms
Total hot run time: 60091 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198414 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6e016f8ce51d5ae945e9a5c8808f4fb763537f3d, data reload: false

query1	1309	933	939	933
query2	6260	2169	2077	2077
query3	10930	4587	4599	4587
query4	33431	23513	23862	23513
query5	4166	471	443	443
query6	277	178	178	178
query7	3999	313	315	313
query8	284	228	218	218
query9	9754	2665	2666	2665
query10	474	280	263	263
query11	17994	15379	14980	14980
query12	154	107	104	104
query13	1542	420	412	412
query14	8702	6692	7490	6692
query15	253	187	195	187
query16	8081	482	500	482
query17	1570	592	567	567
query18	2133	321	310	310
query19	225	158	156	156
query20	118	113	110	110
query21	202	110	106	106
query22	4886	4767	4541	4541
query23	35643	34806	34579	34579
query24	11304	2896	2873	2873
query25	590	400	396	396
query26	1009	182	170	170
query27	2779	353	366	353
query28	7191	2467	2460	2460
query29	736	489	433	433
query30	263	163	162	162
query31	1031	813	828	813
query32	97	56	53	53
query33	770	282	289	282
query34	1112	505	522	505
query35	876	736	724	724
query36	1119	976	999	976
query37	128	67	74	67
query38	4136	3966	3981	3966
query39	1529	1479	1486	1479
query40	211	99	101	99
query41	48	47	47	47
query42	115	100	103	100
query43	520	509	494	494
query44	1274	799	813	799
query45	185	173	171	171
query46	1181	750	742	742
query47	2048	1967	1963	1963
query48	470	373	384	373
query49	991	409	383	383
query50	855	439	415	415
query51	7444	7368	7144	7144
query52	107	94	95	94
query53	254	191	183	183
query54	1179	475	467	467
query55	79	81	77	77
query56	273	246	247	246
query57	1268	1133	1090	1090
query58	244	219	219	219
query59	3270	3104	3294	3104
query60	298	270	271	270
query61	131	163	129	129
query62	913	750	750	750
query63	225	207	187	187
query64	4035	772	728	728
query65	3253	3181	3230	3181
query66	913	309	311	309
query67	15900	15759	15809	15759
query68	4580	580	564	564
query69	458	277	277	277
query70	1211	1129	1156	1129
query71	332	261	286	261
query72	6131	3993	4056	3993
query73	750	345	342	342
query74	10328	9019	9206	9019
query75	3385	2652	2691	2652
query76	2774	1089	1041	1041
query77	390	273	265	265
query78	10507	9676	9543	9543
query79	2418	613	604	604
query80	974	417	430	417
query81	578	244	239	239
query82	679	120	117	117
query83	248	142	141	141
query84	237	86	78	78
query85	1706	288	291	288
query86	491	279	302	279
query87	4394	4288	4338	4288
query88	4281	2392	2375	2375
query89	417	294	294	294
query90	2039	188	183	183
query91	187	151	146	146
query92	62	52	52	52
query93	2212	547	545	545
query94	959	312	307	307
query95	365	258	257	257
query96	613	285	288	285
query97	3362	3145	3161	3145
query98	231	203	201	201
query99	1679	1461	1436	1436
Total cold run time: 303719 ms
Total hot run time: 198414 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6e016f8ce51d5ae945e9a5c8808f4fb763537f3d, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.10	0.10
query5	0.51	0.51	0.50
query6	1.13	0.73	0.73
query7	0.02	0.03	0.01
query8	0.04	0.02	0.03
query9	0.57	0.51	0.49
query10	0.56	0.55	0.58
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.79	2.86	2.78
query15	0.91	0.83	0.83
query16	0.39	0.38	0.39
query17	1.07	1.08	1.04
query18	0.25	0.22	0.22
query19	1.97	1.98	1.82
query20	0.02	0.01	0.00
query21	15.38	0.60	0.59
query22	2.63	2.19	1.59
query23	16.90	0.90	0.77
query24	3.14	0.77	1.52
query25	0.18	0.19	0.10
query26	0.43	0.14	0.13
query27	0.04	0.04	0.05
query28	10.64	1.10	1.08
query29	12.58	3.22	3.19
query30	0.25	0.07	0.06
query31	2.85	0.40	0.40
query32	3.22	0.46	0.45
query33	3.00	3.01	3.04
query34	16.99	4.53	4.50
query35	4.55	4.55	4.57
query36	0.67	0.49	0.48
query37	0.10	0.06	0.07
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 107.02 s
Total hot run time: 32.41 s

@dataroaring dataroaring merged commit a4830a6 into apache:branch-3.0 Feb 10, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants