[refactor](fe) Add fe-foundation module with zero-dependency JDK-only utilities#61175
Merged
CalvinKirs merged 4 commits intoapache:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
… utilities
fe-common has accumulated heavy transitive dependencies (Guava, Hadoop,
Trino SPI, ANTLR, Alibaba SDK, etc.), making it unsuitable for lightweight
consumers such as SPI plugins and fe-extension modules. This creates a new
fe-foundation module that sits at the very bottom of the FE dependency
hierarchy (fe-foundation < fe-extension-spi < fe-common < fe-core) and
carries zero third-party compile dependencies.
Scope of this first iteration:
- Create the fe-foundation Maven module with zero-dependency pom.xml
- Move 10 pure-JDK utility classes from fe-common and fe-core into new
org.apache.doris.foundation.{format,property,type,util} packages:
FormatOptions, ResultOr, ConnectorProperty, ConnectorPropertiesUtils,
ParamRules, StoragePropertiesException, BitUtil, ByteBufferUtil,
PathUtils, SerializationUtils
- Replace trivial Guava/commons-lang3 usage in ConnectorPropertiesUtils
with JDK equivalents (Sets.newHashSet -> new HashSet, StringUtils ->
private isNotBlank method)
- Update all import statements across ~80 consuming files
- Add fe-foundation as dependency in fe-common and fe-core pom.xml
Classes intentionally left in fe-common for future phases:
- Pair/Triple: use Gson @SerializedName, persisted in editlog metadata
- Writable and IO interfaces: 194+ importers deeply embedded in the
persistence/catalog layer
CalvinKirs
force-pushed
the
master-commom-spi-properties
branch
from
a151f03 to
5974b5b
Compare
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 27790 ms |
TPC-DS: Total hot run time: 153482 ms |
morningman
approved these changes
Mar 10, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
hubgeter
approved these changes
Mar 11, 2026
morrySnow
pushed a commit
that referenced
this pull request
Mar 12, 2026
…actor (#61262) ## Problem - commit #61175 moved `ConnectorProperty` from `org.apache.doris.datasource.property` to `org.apache.doris.foundation.property` - `PaimonJdbcMetaStoreProperties` still imported the old package - FE UT on latest master then failed with `cannot find symbol: class ConnectorProperty` ## Fix - switch `PaimonJdbcMetaStoreProperties` to import `org.apache.doris.foundation.property.ConnectorProperty` ## Validation - `./run-fe-ut.sh --run org.apache.doris.datasource.property.metastore.PaimonJdbcMetaStorePropertiesTest`
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Apr 20, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#61175 Problem Summary: Fix the import ordering in InternalCatalog after the fe-foundation backport so fe-core checkstyle passes on branch-4.1. ### Release note None ### Check List (For Author) - Test: FE checkstyle - mvn -pl fe-core -am -DskipTests checkstyle:check -Dcheckstyle.consoleOutput=true - Behavior changed: No - Does this need documentation: No
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Apr 20, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#61175 Problem Summary: Update the branch-4.1-only Paimon JDBC metastore properties class to import ConnectorProperty from fe-foundation and drop an accidentally added VarBinaryLiteralAnalysisTest that does not exist on branch-4.1, restoring FE build success after the fe-foundation backport. ### Release note None ### Check List (For Author) - Test: FE build - env DORIS_PARALLELISM=5 bash build.sh --fe -j5 - Behavior changed: No - Does this need documentation: No
yiguolei
pushed a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Apr 24, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#61175 Problem Summary: Fix the import ordering in InternalCatalog after the fe-foundation backport so fe-core checkstyle passes on branch-4.1. ### Release note None ### Check List (For Author) - Test: FE checkstyle - mvn -pl fe-core -am -DskipTests checkstyle:check -Dcheckstyle.consoleOutput=true - Behavior changed: No - Does this need documentation: No
yiguolei
pushed a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Apr 24, 2026
### What problem does this PR solve? Issue Number: None Related PR: apache#61175 Problem Summary: Update the branch-4.1-only Paimon JDBC metastore properties class to import ConnectorProperty from fe-foundation and drop an accidentally added VarBinaryLiteralAnalysisTest that does not exist on branch-4.1, restoring FE build success after the fe-foundation backport. ### Release note None ### Check List (For Author) - Test: FE build - env DORIS_PARALLELISM=5 bash build.sh --fe -j5 - Behavior changed: No - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
fe-common has accumulated heavy transitive dependencies (Guava, Hadoop, Trino SPI, ANTLR, Alibaba SDK, etc.), making it unsuitable for lightweight consumers such as SPI plugins and fe-extension modules. This creates a new fe-foundation module that sits at the very bottom of the FE dependency hierarchy (fe-foundation < fe-extension-spi < fe-common < fe-core) and carries zero third-party compile dependencies.
Scope of this first iteration:
Classes intentionally left in fe-common for future phases:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)