Skip to content

[fix](load): fix invalid String.format pattern in NereidsStreamLoadTask#62225

Merged
morrySnow merged 1 commit intoapache:masterfrom
foxtail463:invalid_format_pattern
Apr 28, 2026
Merged

[fix](load): fix invalid String.format pattern in NereidsStreamLoadTask#62225
morrySnow merged 1 commit intoapache:masterfrom
foxtail463:invalid_format_pattern

Conversation

@foxtail463
Copy link
Copy Markdown
Contributor

No description provided.

@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Apr 8, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Copy Markdown
Contributor

run buildall

@morrySnow
Copy link
Copy Markdown
Contributor

/review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

PR approved by anyone and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

No issues found in this change.

Critical checkpoint summary:

  • Goal / correctness / test: The patch fixes an invalid String.format pattern in NereidsStreamLoadTask, so unsupported stream-load column expressions now raise the intended UserException instead of a formatting failure. No dedicated test was added for this error path.
  • Change size / focus: Minimal and well-scoped two-line fix in the affected error messages only.
  • Concurrency: Not involved.
  • Lifecycle / static initialization: Not involved.
  • Configuration: Not involved.
  • Compatibility: No incompatible API, protocol, or storage-format change.
  • Parallel code paths: I did not find the same broken format string elsewhere in FE Java sources.
  • Special conditional checks: No new conditions added.
  • Test coverage: Existing automated coverage for this exact failure path was not found, but the code change is straightforward and low risk.
  • Observability: No additional observability needed for this fix.
  • Transaction / persistence: Not involved.
  • Data writes / atomicity: Not involved.
  • FE/BE variable passing: Not involved.
  • Performance: No impact.
  • Other issues: None identified.

Applicable module checkpoints:

  • FE exceptions: The method continues to surface a user-facing checked UserException; this patch only restores the intended message formatting.
  • Nereids-specific review items: No rule, property-derivation, or optimizer-stage behavior is changed here.

@starocean999 starocean999 changed the title fix(load): fix invalid String.format pattern in NereidsStreamLoadTask [fix](load): fix invalid String.format pattern in NereidsStreamLoadTask Apr 8, 2026
@caiconghui caiconghui self-requested a review April 8, 2026 09:00
@hello-stephen
Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit 9f70b43 into apache:master Apr 28, 2026
33 of 35 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 28, 2026
…sk (#62225)

Co-authored-by: yangtao555 <yangtao555@jd.com>
github-actions Bot pushed a commit that referenced this pull request Apr 28, 2026
…sk (#62225)

Co-authored-by: yangtao555 <yangtao555@jd.com>
yiguolei pushed a commit that referenced this pull request Apr 29, 2026
…StreamLoadTask #62225 (#62895)

Cherry-picked from #62225

Co-authored-by: foxtail463 <foxtail463@gmail.com>
Co-authored-by: yangtao555 <yangtao555@jd.com>
yiguolei pushed a commit that referenced this pull request May 10, 2026
…StreamLoadTask #62225 (#62894)

Cherry-picked from #62225

Co-authored-by: foxtail463 <foxtail463@gmail.com>
Co-authored-by: yangtao555 <yangtao555@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.6-merged dev/4.1.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants