[improvement](fe) Add virtual compute group switch metric#63036
Merged
luwei16 merged 1 commit intoMay 9, 2026
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
luwei16
force-pushed
the
codex/virtual-cluster-switch-metrics
branch
from
57b917c to
d0cef2d
Compare
Contributor
Author
|
run buildall |
gavinchou
reviewed
May 7, 2026
| protected static AutoMappedMetric<LongCounterMetric> CLUSTER_CLOUD_GLOBAL_BALANCE_NUM; | ||
| protected static AutoMappedMetric<LongCounterMetric> CLUSTER_CLOUD_SMOOTH_UPGRADE_BALANCE_NUM; | ||
| protected static AutoMappedMetric<LongCounterMetric> CLUSTER_CLOUD_WARM_UP_CACHE_BALANCE_NUM; | ||
| protected static AutoMappedMetric<LongCounterMetric> VIRTUAL_CLUSTER_SWITCH_COUNTER; |
Contributor
Author
There was a problem hiding this comment.
Done. Renamed the new metric/API/labels from virtual cluster terminology to virtual compute group terminology. The exposed metric is now doris_fe_virtual_compute_group_switch_total with *_compute_group_* labels.
gavinchou
reviewed
May 7, 2026
| List<MetricLabel> labels = new ArrayList<>(); | ||
| counter.increase(1L); | ||
| labels.add(new MetricLabel("virtual_cluster_id", virtualClusterId)); | ||
| labels.add(new MetricLabel("virtual_cluster_name", virtualClusterName)); |
Contributor
There was a problem hiding this comment.
what happen to a renamed compute group,
the existed metrics with wrong names seem never disappare?
Contributor
Author
There was a problem hiding this comment.
Fixed. The internal AutoMappedMetric key now uses virtual/src/dst compute group ids instead of names. When the same ids are reported with updated names, FE removes the old registered label series before setting the new labels, so renamed compute groups do not leave stale old-name metrics. Added MetricsTest.testVirtualComputeGroupSwitchMetricRename to cover this case.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Add an FE cloud metric that records virtual compute group active-standby switch events. The metric key uses virtual/src/dst compute group ids so a compute group rename updates the exposed labels without leaving stale old-name series.
### Metric example
Prometheus output example:
```text
# HELP doris_fe_virtual_compute_group_switch_total virtual compute group active standby switch count
# TYPE doris_fe_virtual_compute_group_switch_total counter
doris_fe_virtual_compute_group_switch_total{virtual_compute_group_id="id1",virtual_compute_group_name="v_group_1",src_compute_group_id="id2",src_compute_group_name="p_group_1",dst_compute_group_id="id3",dst_compute_group_name="p_group_2"} 1
```
The metric value is the accumulated switch count for the labeled virtual compute group switch path.
### Release note
Add FE metric doris_fe_virtual_compute_group_switch_total for virtual compute group active-standby switches.
### Check List (For Author)
- Test:
- Unit Test: bash run-fe-ut.sh --run org.apache.doris.cloud.system.CloudSystemInfoServiceTest
- Unit Test: bash run-fe-ut.sh --run org.apache.doris.metric.MetricsTest
- Manual test: git diff --check
- FE checkstyle: bash -lc "export DORIS_HOME=$PWD && source env.sh && cd fe && ${MVN_CMD} -pl fe-core -DskipTests checkstyle:check"
- Behavior changed: Yes. Add a new FE metric for virtual compute group active-standby switches.
- Does this need documentation: No
luwei16
force-pushed
the
codex/virtual-cluster-switch-metrics
branch
from
d0cef2d to
034d322
Compare
gavinchou
approved these changes
May 7, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
changed the title
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Add an FE cloud metric that records virtual compute group active-standby switch events. The metric key uses virtual/src/dst compute group ids so a compute group rename updates the exposed labels without leaving stale old-name series.
Metric example
Prometheus output example:
The metric value is the accumulated switch count for the labeled virtual compute group switch path.
Release note
Add FE metric doris_fe_virtual_compute_group_switch_total for virtual compute group active-standby switches.
Check List (For Author)