[fix](be) Load JNI log4j2 properties config#63063
Merged
Gabriel39 merged 1 commit intoapache:masterfrom May 8, 2026
Merged
Conversation
Issue Number: close #xxx Related PR: #xxx Problem Summary: ScannerLoader forced log4j2.xml even when the file-based log4j2.properties resource should be used, causing JNI logs to keep using the XML configuration. None - Test: No need to test (single configuration file name change; not run) - Behavior changed: Yes (ScannerLoader now loads log4j2.properties instead of log4j2.xml) - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
approved these changes
May 8, 2026
Contributor
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
/review |
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2026
Problem Summary: ScannerLoader forced log4j2.xml even when the file-based log4j2.properties resource should be used, causing JNI logs to keep using the XML configuration.
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2026
Problem Summary: ScannerLoader forced log4j2.xml even when the file-based log4j2.properties resource should be used, causing JNI logs to keep using the XML configuration.
Contributor
There was a problem hiding this comment.
No blocking findings found in this review.
Critical checkpoint conclusions:
- Goal and test proof: The PR changes
ScannerLoaderto point Log4j2 at the existinglog4j2.propertiesclasspath resource and removes the stalelog4j2.xml. This accomplishes the stated goal. No test was run, but the change is narrowly scoped to a resource name and stale resource removal. - Scope: The modification is small and focused.
- Concurrency: No new concurrency or shared mutable lifecycle behavior is introduced.
- Lifecycle/static initialization: The touched code is in an existing static initializer; the change only changes the configuration filename used before
LoggerContext.reconfigure(). - Configuration items: No Doris config item is added.
- Compatibility/storage/protocol: No storage format, RPC, thrift, or mixed-version protocol behavior is changed.
- Parallel paths: I found no remaining
log4j2.xmlreferences infe/be-java-extensions/java-common;log4j2.propertiesis present in the module resources. - Special checks/error handling: No new checks or error-handling paths are added.
- Test coverage: No tests were added or run; acceptable risk for this small packaging/logging resource correction, but runtime verification in the JNI scanner package would still be useful.
- Observability: The change directly affects logging configuration; the existing initialization log remains.
- Transaction/data correctness: Not applicable.
- Performance: Not applicable.
User focus: No additional user-provided review focus was present.
yiguolei
pushed a commit
that referenced
this pull request
May 9, 2026
yiguolei
pushed a commit
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: ScannerLoader forced log4j2.xml even when the file-based log4j2.properties resource should be used, causing JNI logs to keep using the XML configuration.
None
Test: No need to test (single configuration file name change; not run)
Behavior changed: Yes (ScannerLoader now loads log4j2.properties instead of log4j2.xml)
Does this need documentation: No
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)