Skip to content

branch-4.1: [fix](variant) Fix variant flat-leaf root read plan #63086 #63104#63098

Merged
yiguolei merged 3 commits intobranch-4.1from
auto-pick-63086-branch-4.1
May 10, 2026
Merged

branch-4.1: [fix](variant) Fix variant flat-leaf root read plan #63086 #63104#63098
yiguolei merged 3 commits intobranch-4.1from
auto-pick-63086-branch-4.1

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 9, 2026

Cherry-picked from #63086 #63104

Problem Summary: Flat-leaf compaction/checksum mode should keep root
variant reads on the root-flat path and should not fall back to
doc-value root reconstruction. Avoid probing an empty leaf path, keep
explicit doc bucket columns on DOC_COMPACT, and update the doc-bucket
unit test to assert that root uses VariantRootColumnIterator in
flat-leaf mode.
@github-actions github-actions Bot requested a review from yiguolei as a code owner May 9, 2026 06:39
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.26% (20070/37684)
Line Coverage 36.75% (189128/514650)
Region Coverage 33.07% (147056/444618)
Branch Coverage 34.16% (64352/188372)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (26362/36878)
Line Coverage 54.50% (279498/512801)
Region Coverage 51.56% (231261/448516)
Branch Coverage 53.03% (100169/188882)

@eldenmoon
Copy link
Copy Markdown
Member

run buildall

@eldenmoon eldenmoon changed the title branch-4.1: [fix](variant) Fix variant flat-leaf root read plan #63086 branch-4.1: [fix](variant) Fix variant flat-leaf root read plan #63086 #63104 May 9, 2026
@hello-stephen
Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 89.47% (34/38) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.26% (20068/37681)
Line Coverage 36.77% (189213/514650)
Region Coverage 33.11% (147188/444560)
Branch Coverage 34.17% (64372/188365)

@hello-stephen
Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 89.47% (34/38) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.54% (26382/36877)
Line Coverage 54.56% (279810/512819)
Region Coverage 52.04% (233394/448471)
Branch Coverage 53.23% (100536/188885)

@yiguolei yiguolei merged commit 8881ac9 into branch-4.1 May 10, 2026
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants