-
Notifications
You must be signed in to change notification settings - Fork 975
fix: replace panic with error handling for cluster extension failure #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3021 +/- ##
===========================================
- Coverage 39.62% 39.59% -0.03%
===========================================
Files 457 457
Lines 38878 38901 +23
===========================================
- Hits 15406 15404 -2
- Misses 22214 22237 +23
- Partials 1258 1260 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because no error is returned here, if it is adjusted to return nil, is there a risk of panic in other referenced places? If so, including unit tests, they also need to be adjusted.
got it. I'll look for other places that reference it. |
|
I prefer to use panic to deal with these serious and irreverable problems. |
|



What does this PR do?
Replaces panic with proper error handling when cluster extension fails. This prevents the application from crashing and allows errors to be handled gracefully.
Why is it needed?
Using error handling instead of panic improves system stability and reliability.
Related to #3008