-
Notifications
You must be signed in to change notification settings - Fork 975
fix(filter/trace): adjust the trace scope name with the otel spec #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aligns the trace scope name with OpenTelemetry specification requirements by replacing the generic OTel package name with a specific Dubbo-related scope name.
- Updates trace scope name to use a Dubbo-specific identifier instead of the generic OpenTelemetry package name
- Removes dependency on the OTel SDK package and switches to local version constant
- Improves code documentation and consistency with interface assertion patterns
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| filter/otel/trace/filter.go | Updates tracer scope name and version constant, adds documentation comments, and improves variable naming |
| filter/otel/trace/attachment.go | Improves interface assertion pattern and removes extra blank lines |
| common/constant/otel.go | Replaces generic OTel package name constant with Dubbo-specific trace scope name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
这是那个 gpt 的解释 该 CI 工作失败的原因如下: 原因工作流尝试执行 git 操作时, 解决方法1. 确保在运行工作流步骤前工作目录是干净的。 - name: Reset any local changes
run: git reset --hard HEAD2. 如果工作流过程中确实需要修改文件,请确保在需要时 add 并 commit,或者在继续之前还原这些修改。 3. 如果 工作流修正示例你可以在 jobs:
build:
steps:
- uses: actions/checkout@v3
# 添加这个步骤
- name: Reset local changes to ensure clean state
run: git reset --hard HEAD
# 其他步骤...摘要: 如需更具体代码或想查看相关 workflow 文件,请告知! 是的,这个问题属于 GitHub CI/CD 工作流配置导致的。 解决方法 - name: Reset local changes to ensure clean state
run: git reset --hard HEAD这样能避免因本地未提交的文件修改导致 CI/CD 失败。 如果你有特殊需要的文件变更,要么在工作流中 add & commit,要么把相关文件加入 总结 |
|
done. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
- Coverage 39.64% 39.61% -0.04%
===========================================
Files 457 457
Lines 39075 39075
===========================================
- Hits 15493 15480 -13
- Misses 22318 22332 +14
+ Partials 1264 1263 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|






Align the trace scope name with the OpenTelemetry (OTel) specification.
https://github.com/open-telemetry/opentelemetry-specification/blob/1e04e1be0e17cae6d01c862049bbeb298e0ffa06/specification/metrics/api.md#get-a-meter