FINERACT-2169: New command processing infrastructure #4281
Conversation
vidakovic
force-pushed
the
feature/FINERACT-2169
branch
from
9fa080d to
300f88a
Compare
| @@ -0,0 +1,35 @@ | |||
| ⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣰⣿⣷⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀ | |||
There was a problem hiding this comment.
... ah... Kristof... can't hide anything from your eyes 😄
vidakovic
force-pushed
the
feature/FINERACT-2169
branch
from
300f88a to
558bcc9
Compare
fineract-command/src/main/java/org/apache/fineract/command/core/CommandProperties.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public <REQ, RES> Supplier<RES> execute(Command<REQ> command) { | ||
| CompletableFuture<RES> future = null; |
There was a problem hiding this comment.
I think this is unnecessary😅, probably be better init on single line.. I think it will be better at least for code style
There was a problem hiding this comment.
Sure... we save one line.
fineract-command/src/test/java/org/apache/fineract/command/sample/web/DummyApiController.java
Show resolved
Hide resolved
...ract-command/src/test/java/org/apache/fineract/command/sample/web/DummyExceptionHandler.java
Show resolved
Hide resolved
|
v1.11 is coming soon... we don't want this in 1.11, right? Just trying to keep an eye on this since I'm working with James on the v1.11 release today. |
|
@meonkeys ... I'd say let's leave this one out of 1.11 ... it would have no impact, but still, let's keep this one out. Feel free to progress with the release. |
|
Perfect, thanks @vidakovic . Should be easy as long as it isn't merged into Cc: @jdailey |
More details at...
Jira: https://issues.apache.org/jira/browse/FINERACT-2169
Wiki: https://cwiki.apache.org/confluence/display/FINERACT/FSIP-5%3A+New+command+processing+infrastructure