[FLINK-36784][common] Support to add metadata columns for data in the meta fields of DataChangeEvent at transform #3758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanhang1993
force-pushed
the
flink36784
branch
from
17b61d5 to
35d174e
Compare
ruanhang1993
force-pushed
the
flink36784
branch
from
35d174e to
ac4c708
Compare
lvyanquan
approved these changes
Dec 5, 2024
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/source/SupportedMetadataColumn.java
Outdated
Show resolved
Hide resolved
yuxiqian
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks for @ruanhang1993's nice work, looks nice overall. Just left some optional comments that should not block this PR.
Comment on lines
79
to
84
| tableInfo, | ||
| transformFilter, | ||
| timezone, | ||
| udfDescriptors, | ||
| udfFunctionInstances, | ||
| supportedMetadataColumns); |
There was a problem hiding this comment.
Feels like we need something like TransformContext to gather all these things together instead of extending arguments lists forever, but it's not a must in this PR.
There was a problem hiding this comment.
Thanks for this suggestion. Let open a new issue for this optimization.
...src/main/java/org/apache/flink/cdc/runtime/operators/transform/TransformFilterProcessor.java
Outdated
Show resolved
Hide resolved
ruanhang1993
force-pushed
the
flink36784
branch
from
ac4c708 to
f6bd9d6
Compare
ruanhang1993
force-pushed
the
flink36784
branch
from
f6bd9d6 to
b19b585
Compare
ruanhang1993
force-pushed
the
flink36784
branch
from
b19b585 to
eaa6152
Compare
lvyanquan
approved these changes
Dec 18, 2024
ruanhang1993
force-pushed
the
flink36784
branch
from
9778882 to
a1c8227
Compare
yuxiqian
reviewed
Dec 19, 2024
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java
Show resolved
Hide resolved
...ysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java
Outdated
Show resolved
Hide resolved
...mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java
Outdated
Show resolved
Hide resolved
...-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/metadata/MetadataColumns.java
Outdated
Show resolved
Hide resolved
… meta fields of DataChangeEvent at transform
…in MySqlDataSource to pass metadata info like op_ts to downstream.
ruanhang1993
force-pushed
the
flink36784
branch
from
11fea9d to
a503ee9
Compare
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… meta fields of DataChangeEvent at transform (apache#3758) Co-authored-by: Kunni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports to add metadata in the meta field of DataChangeEvent at transform.