[FLINK-37096][cdc-connect] fix The purpose of the issue is to change the value of the delay curve from 20098d to -1ms in the full phase. #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the value of the delay curve from 20098d to -1ms in the full phase.
MongoDBParallelSourceITCase are all passed the test
|
yuxiqian
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Thanks for @Sukang1002's nice work! Just left some trivial comments about codestyle and tests.
|
|
||
| if (isInDbSnapshotPhase && !isSnapshotRecord(record)) { | ||
| // Wait for the end of the snapshot phase for the first data to trigger subsequent calculations. | ||
| if (isInDbSnapshotPhase && !isSnapshotRecord(record) && messageTimestamp !=0) { |
There was a problem hiding this comment.
Please make sure that mvn spotless:apply / mvn spotless:check have been executed before committing to resolve any codestyle violations
| emitDelay = | ||
| isInDbSnapshotPhase ? 0L : System.currentTimeMillis() - messageTimestamp; | ||
| isInDbSnapshotPhase ? -1L : System.currentTimeMillis() - messageTimestamp; |
There was a problem hiding this comment.
Maybe we can verify this change by adding a test case similar to MySqlSourceITCase#testSourceMetrics
|
@yuxiqian PTAL. |
MongoDBMetricCase#testSourceMetrics can be tested locally. Have any problem, hard teachers to point out.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc:FLINK-37096