-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37201] [cdc] [transform] FlinkCDC Pipeline transform arithmetic functions support parameters of null and more numerical types #3881
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @aiwenmo's great work! Looks nice, just left some trivial comments.
...composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java
Outdated
Show resolved
Hide resolved
...composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java
Outdated
Show resolved
Hide resolved
...composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineTransformITCase.java
Outdated
Show resolved
Hide resolved
@yuxiqian PTAL |
Would @leonardBang like to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…c functions support parameters of null and more numerical types
Hi @leonardBang , I have rebased master. Could you help trigger the actions again? thx |
@leonardBang Sorry. Please help me trigger it after resolving the exception on the master branch. |
FlinkCDC Pipeline transform arithmetic functions can not support parameters of null and more numerical types. For example: ceil, floor, round and abs.
When the input parameter is null or a numerical type such as int, the program will have an error.
I have fixed it.