Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37201] [cdc] [transform] FlinkCDC Pipeline transform arithmetic functions support parameters of null and more numerical types #3881

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aiwenmo
Copy link
Contributor

@aiwenmo aiwenmo commented Jan 22, 2025

FlinkCDC Pipeline transform arithmetic functions can not support parameters of null and more numerical types. For example: ceil, floor, round and abs.
When the input parameter is null or a numerical type such as int, the program will have an error.
I have fixed it.

  1. ceil, floor, round support null parameter and more numerical types, such as byte, short, int ,long, decimaldata.
  2. abs support null parameter.
  3. add ceiling function, which has the same function as ceil.
  4. add test and document.

@github-actions github-actions bot added docs Improvements or additions to documentation composer runtime labels Jan 22, 2025
Copy link
Contributor

@yuxiqian yuxiqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for @aiwenmo's great work! Looks nice, just left some trivial comments.

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Feb 10, 2025

@yuxiqian PTAL

@yuxiqian
Copy link
Contributor

Would @leonardBang like to take a look?

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aiwenmo for the improvement and @yuxiqian for the review work, LGTM

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Feb 12, 2025

Hi @leonardBang , I have rebased master. Could you help trigger the actions again? thx

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Feb 12, 2025

@leonardBang Sorry. Please help me trigger it after resolving the exception on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved composer docs Improvements or additions to documentation reviewed runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants