Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35886] Leave a note for future Flink 2.0 upgrade #114

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[FLINK-35886] Leave a note for future Flink 2.0 upgrade #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,14 @@ private List<KafkaTopicPartitionState<T, KPH>> createPartitionStateHolders(
kafkaHandle,
deserializedWatermarkStrategy.createTimestampAssigner(
() -> consumerMetricGroup),
// When upgrading to Flink 2.0, context has to provide also
// the input activity clock. This is not trivial for the old
// sources. Ideally we should drop this old source before
// this connector is upgraded to Flink 2.0. Otherwise, we
// can avoid the compilation error without fixing the bug
// addressed by the FLIP-471, by returning SystemClock,
// which would reproduce the pre-FLIP-471 behavior (without
// fixing the underlying bug).
deserializedWatermarkStrategy.createWatermarkGenerator(
() -> consumerMetricGroup),
immediateOutput,
Expand Down
Loading