-
Notifications
You must be signed in to change notification settings - Fork 167
[FLINK-38289] Update to Flink 2.1 #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests are pending. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please spotless the code
Believe me I am trying, but running |
So the reason it skips it locally is that it is defaulted to that in the connector parent pom. I am not sure what in the ci config overrides that, but I had to manually add the spotless plugin to the build config, and set skip to false, in each child module to get it to run. |
Leaving it open for couple of days in order to wait for comments from others. |
@tomncooper looks like you have conflicts |
Signed-off-by: Thomas Cooper <[email protected]>
…nk 2.1 Signed-off-by: Thomas Cooper <[email protected]>
hi @gaborgsomogyi , is there any release planned ? flink 2.1 and kafka 4.0 are great new features Thanks |
First I need to release Flink 2.1.1 and then we can take a look at this connector... |
when publish? i not found it in mvnrepository . |
This PR updates the Flink version to 2.1.0.
The main issue with this update is that Flink has removed (without deprecating first) the
stripRowPrefix
method from theDataTypeUtilsTest
class. So this PR adds that logic into a util class within the connector.Also note that with the update to Flink 2.1.0 the connector drops support for Python 3.8, I added testing for Python 3.11 but 3.12-cython (2.1 added support for Python 3.12) is not yet available.