Skip to content

Conversation

tomncooper
Copy link
Contributor

@tomncooper tomncooper commented Aug 27, 2025

This PR updates the Flink version to 2.1.0.

The main issue with this update is that Flink has removed (without deprecating first) the stripRowPrefix method from the DataTypeUtilsTest class. So this PR adds that logic into a util class within the connector.

Also note that with the update to Flink 2.1.0 the connector drops support for Python 3.8, I added testing for Python 3.11 but 3.12-cython (2.1 added support for Python 3.12) is not yet available.

@gaborgsomogyi
Copy link
Contributor

Tests are pending.

Copy link
Contributor

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please spotless the code

@tomncooper
Copy link
Contributor Author

Please spotless the code

Believe me I am trying, but running mvn spotless:check locally (with maven 3.8.6 and Java 17) reveals no issues. It appears all the checks are skipped?

@tomncooper
Copy link
Contributor Author

So the reason it skips it locally is that it is defaulted to that in the connector parent pom. I am not sure what in the ci config overrides that, but I had to manually add the spotless plugin to the build config, and set skip to false, in each child module to get it to run.

@gaborgsomogyi
Copy link
Contributor

Leaving it open for couple of days in order to wait for comments from others.

@davidradl
Copy link

@tomncooper looks like you have conflicts

@gaborgsomogyi gaborgsomogyi merged commit 032c9dd into apache:main Aug 30, 2025
6 checks passed
@raphaelauv
Copy link

hi @gaborgsomogyi , is there any release planned ?

flink 2.1 and kafka 4.0 are great new features

Thanks

@gaborgsomogyi
Copy link
Contributor

First I need to release Flink 2.1.1 and then we can take a look at this connector...

@jessechencx
Copy link

when publish? i not found it in mvnrepository .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants