Skip to content

[FLINK-39138] Update to flink connector parent pom version 2.0#233

Open
tomncooper wants to merge 1 commit intoapache:mainfrom
tomncooper:flink-connector-parent-2.0
Open

[FLINK-39138] Update to flink connector parent pom version 2.0#233
tomncooper wants to merge 1 commit intoapache:mainfrom
tomncooper:flink-connector-parent-2.0

Conversation

@tomncooper
Copy link
Contributor

@tomncooper tomncooper commented Feb 23, 2026 •
edited
Loading

This PR updates to the newly released Flink-Connector-Parent POM version 2.0. This update:

  • Drops Java 8 support
  • Updates the Checkstyle plugin config to match the one from the main Flink project's
  • Spotless check fixes

@tomncooper tomncooper force-pushed the flink-connector-parent-2.0 branch from 8c99447 to a6fcd87 Compare February 23, 2026 11:12
@tomncooper
Copy link
Contributor Author

tomncooper commented Feb 23, 2026 •
edited
Loading

To get this to pass CI we need to pass the -P java11-target profile to the maven build. We can do that in each connector repo, or we can just fix it at the source. So I am working on a PR to the flink-connector-shared-utils repo to fix this in the base github action.

@tomncooper
Copy link
Contributor Author

tomncooper commented Feb 23, 2026

I pushed a PR to the Connector Shared Utils repo to add the Java 11 target profile automatically in the CI. That will need to be merged first for the CI on this PR to pass.

gguptp
gguptp reviewed Feb 23, 2026
View reviewed changes
Copy link

@gguptp gguptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomncooper i see that there are some merge conflicts coming in with license files, do we need to fix them?

@tomncooper
Copy link
Contributor Author

tomncooper commented Feb 23, 2026

@tomncooper i see that there are some merge conflicts coming in with license files, do we need to fix them?

I fixed them AFAICS?

@tomncooper
Copy link
Contributor Author

tomncooper commented Feb 23, 2026

Sigh I used the GH UI and it has messed up the merge. Let me hack it back into shape.

@tomncooper
[FLINK-39138] Update to flink connector parent pom version 2.0
15eed72 
* Drops Java 8 support
* Updates the Checkstyle plugin config to match the one from the main Flink project's
* Adds missing licence headers as the Apache Rat plugin now runs by default

Signed-off-by: Thomas Cooper <code@tomcooper.dev>
@tomncooper tomncooper force-pushed the flink-connector-parent-2.0 branch from 24863fa to 15eed72 Compare February 23, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gguptp gguptp gguptp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component=BuildSystem component=Connectors/Kafka

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomncooper @gguptp