Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34193][Connectors/Kafka] Remove usage of Flink-Shaded Jackson and Snakeyaml in flink-connector-kafka #83

Closed
wants to merge 1 commit into from

Conversation

jinsuichen
Copy link

What is the purpose of the change

This pull request removes the dependency on shaded.

Brief change log

  • Due to the @PublicEvolving annotation marking JSONKeyValueDeserializationSchema.java, the specific version of Jackson it uses is retained and cannot be removed. Therefore, in KafkaRecordDeserializationSchemaTest.java, the ObjectNode is changed to use the same dependency instead of relying on shaded.
  • In KafkaRecordDeserializationSchemaTest.java, JsonDeserializationSchema indirectly depends on shaded, so it is replaced with an inner class SimpleDeserializationSchema.
  • The YAML serialization and deserialization logic in YamlFileMetaDataService.java is replaced with JSON.

Verifying this change

This change is already covered by existing tests, such as JsonFileMetadataServiceTest.java.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Copy link

boring-cyborg bot commented Jan 29, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@jinsuichen
Copy link
Author

Hi, @MartijnVisser. All CI jobs have been passed in my own repo forked from here. PR link

Could you help me retry the failed one?

@MartijnVisser
Copy link
Contributor

Superseded by #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants