[FLINK-13230] [pubsub] Add retry mechanism to acknowledging pubsub me…

[Xeli]

What is the purpose of the change

Follow up on PubSub connector PR. This adds a retry mechanism to acknowledging pubsub messages. Google's PubSub is unstable enough for this to be a must-have imo.

Brief change log

Verifying this change

Trivial change.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with @Public(Evolving): Yes, unless we can add this to 1.9. The pubsub connector has not yet been released.
• The serializers: no
• The runtime per-record code paths (performance sensitive): Yes, but only for the pubsub connector, not the flink core code.
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
• The S3 file system connector: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? JavaDocs

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit b52890e (Wed Oct 16 08:43:32 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• b52890e Unknown: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[Xeli]

@becketqin as you've looked at the pubsub code the most: Would you be so kind to have a look at this PR? We can then close https://issues.apache.org/jira/browse/FLINK-13083

[becketqin]

We probably don't want to have recursion in the retry logic. Can we replace it with a for loop instead?

[RyanSkraba]

The changes in this PR have been applied (with attribution to @Xeli!) to the new FLIP-27 Pub/Sub connector in apache/flink-connector-gcp-pubsub#2, and this PR might be closeable. What do you think?

[snuyanzin]

thanks @RyanSkraba
yes, since pubsub connector is externalised it makes sense to close it
Also @RyanSkraba could you please comment about that

The changes in this PR have been applied (with attribution to @Xeli!) to the new FLIP-27 Pub/Sub connector in apache/flink-connector-gcp-pubsub#2,

in jira issue as well?