GUACAMOLE-2030: Fix KSM static token mapping for per-user config. #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugen-keeper
force-pushed
the
fix-static-tokens-per-user-ksm
branch
3 times, most recently
from
4d19817 to
f772c84
Compare
necouchman
reviewed
Feb 11, 2025
Comment on lines
677
to
678
| + "the documentation at {} for valid formatting.", | ||
| notation, KEEPER_NOTATION_DOC_URL); |
There was a problem hiding this comment.
Minor style nitpick, but I think these two lines should be further indented to match up with the indentation of the logger.warn() line above?
eugen-keeper
force-pushed
the
fix-static-tokens-per-user-ksm
branch
from
f772c84 to
14dc180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue plus changes log messages for this case:
16:52:41.850 [http-nio-8080-exec-10] WARN o.a.g.vault.ksm.secret.KsmClient - "keeper://XXX/field/login" could not be resolved: Record 'XXX' not found16:52:42.442 [http-nio-8080-exec-10] WARN o.a.g.vault.ksm.secret.KsmClient - "keeper://XXX/field/password" could not be resolved: Record 'XXX' not found