GUACAMOLE-2032: Fix hasClientGroups() to no longer take into account the currently attached client. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. |
mike-jumper
requested changes
Feb 15, 2025
guacamole/src/main/frontend/src/app/client/directives/guacClientPanel.js
Outdated
Show resolved
Hide resolved
…the currently attached client.
corentin-soriano
force-pushed
the
GUACAMOLE-2032_empty_rectangle
branch
from
967a1b9 to
846f811
Compare
mike-jumper
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the function systematically returns true and leaves this small rectangle visible:
The fix allows this element to only be displayed when there is at least one unattached client.