Skip to content

Conversation

@stcbus
Copy link

@stcbus stcbus commented Jun 23, 2025

This is the start of a pull request to address GUACAMOLE-954 in a performant way, but unfortunately this feature only works with Active Directory (as far as I am aware).

I added a new config boolean due to this called 'nested-groups' to enable/disable the AD-specific query.

It makes use of the LDAP_MATCHING_RULE_IN_CHAIN mentioned in the Jira with a specific OID.

I understand if the team is not keen on merging a feature that is only for a specific vendor's LDAP implementation, but this is performant and very useful for us in our AD environment so I would like to try and get it added for the others who requested it and likely using AD as well.

@necouchman
Copy link
Contributor

I understand if the team is not keen on merging a feature that is only for a specific vendor's LDAP implementation, but this is performant and very useful for us in our AD environment so I would like to try and get it added for the others who requested it and likely using AD as well.

Personally I think it would be fine to have this feature included, provided we clearly document when it is expected to work and when it probably will not work. Many other software applications out there that leverage LDAP have ways of configuring the type of LDAP server you're pointing to in order to make use of specific features, and I agree that it would be useful for folks pointing at AD-based LDAP servers.

@stcbus
Copy link
Author

stcbus commented Oct 20, 2025

@necouchman Added it as a final string.

Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor comment update, and I think this will be ready to merge.

@necouchman necouchman merged commit 74e3b34 into apache:main Oct 30, 2025
1 check passed
@necouchman
Copy link
Contributor

Thanks @stcbus! If you could also update the apache/guacamole-manual with a PR, that would be helpful to make sure documentation is up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants