GUACAMOLE-1957: Support granular permissions management. #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
force-pushed
the
working/permissions-management
branch
2 times, most recently
from
a25618c to
94b691b
Compare
necouchman
force-pushed
the
working/permissions-management
branch
from
94b691b to
5d82238
Compare
|
Interesting! |
"Interesting" can be such an ambiguous word. 🤣 |
Heh - true. I think I like this approach, though. I'm curious how well it scales for larger numbers of connections. |
Definitely a good point - I don't have all that many to test with in a test environment at the moment, so not sure how well the pagination works with it at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken a stab at making the permissions management a bit more granular, allowing the four possible object-level permissions to be managed individually for connections, connection groups, and sharing profiles. As usual, I could use suggestions for how the GUI might be better set up to support this - I was originally going to try to create a table; however, going that route would require reworking the entire permissions management system, possibly implementing some sort of
guac-group-tabledirective or something like that. So, I opted for a little simpler route.Here's how it looks in practice:
