Skip to content

Commit

Permalink
Merge r1917017, r1923218 from trunk:
Browse files Browse the repository at this point in the history
* server/core.c (set_override): Catch errors returned by
  set_allow_opts() for a parsing fail in an Options= argument.

Submitted by: Zhou Qingyang <zhou1615 umn.edu>
Github: closes #310

Add a Changes entry related to r1917017

While at it, fix a small style issue (tab vs spaces)

Submitted by: jorton, jailletc36
Reviewed by: rjung (reduce code drift), jorton, jailletc36


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1923804 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
notroj committed Feb 14, 2025
1 parent ad2371e commit 8486d22
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changes-entries/github 310.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*) core: Report invalid Options= argument when parsing AllowOverride
directives.
Github #310 [Zhou Qingyang <zhou1615 umn.edu>]
6 changes: 4 additions & 2 deletions server/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1838,8 +1838,10 @@ static const char *set_override(cmd_parms *cmd, void *d_, const char *l)
}
else if (!ap_cstr_casecmp(k, "Options")) {
d->override |= OR_OPTIONS;
if (v)
set_allow_opts(cmd, &(d->override_opts), v);
if (v) {
if ((err = set_allow_opts(cmd, &(d->override_opts), v)) != NULL)
return err;
}
else
d->override_opts = OPT_ALL;
}
Expand Down

0 comments on commit 8486d22

Please sign in to comment.