Skip to content

Restrict trigger push branch for GitHub Workflow#2757

Merged
blackmwk merged 2 commits into
apache:mainfrom
apupier:configureTriggerPushForGitHubWorkflows
Jul 3, 2026
Merged

Restrict trigger push branch for GitHub Workflow#2757
blackmwk merged 2 commits into
apache:mainfrom
apupier:configureTriggerPushForGitHubWorkflows

Conversation

@apupier

@apupier apupier commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Feature branches rarely need their own CI runs: the code is already tested when a pull request is opened against a release branch. If the push trigger has no branch restriction and pull_request is also configured, every push to a branch with an open PR runs the workflow twice: once for the push and once for the PR synchronisation.

Always give the push trigger an explicit list of branches: this stops branches created from a release branch from inheriting its workflow runs.

see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Are these changes tested?

Feature branches rarely need their own CI runs: the code is already
tested when a pull request is opened against a release branch. If the
push trigger has no branch restriction and pull_request is also
configured, every push to a branch with an open PR runs the workflow
twice: once for the push and once for the PR synchronisation.

Always give the push trigger an explicit list of branches: this stops
branches created from a release branch from inheriting its workflow
runs.

see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=430408443#GitHubActionsRecommendedPractices-Restrictthepushtriggertospecificbranches

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier

apupier commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

error in PR check security audit is unrelated to this PR

@blackmwk blackmwk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apupier for this pr!

@blackmwk blackmwk merged commit 46fd317 into apache:main Jul 3, 2026
22 checks passed
@apupier apupier deleted the configureTriggerPushForGitHubWorkflows branch July 3, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants