Skip to content

chore: update verify_rc script to verify tag against tarball#2760

Merged
blackmwk merged 2 commits into
apache:mainfrom
CTTY:ctty/verify-release-tag
Jul 3, 2026
Merged

chore: update verify_rc script to verify tag against tarball#2760
blackmwk merged 2 commits into
apache:mainfrom
CTTY:ctty/verify-release-tag

Conversation

@CTTY

@CTTY CTTY commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

  • Updated verify_rc.sh to verify tag against tarball on Apache dev repo

Are these changes tested?

Manually tested against v0.10.0-rc.2, see results in the comment

Comment thread dev/release/verify_rc.sh
--verify_git_tag <0|1>
Whether to verify that the source archive matches the git tag v<version>-rc.<rc>.
The tag is cloned and re-archived, then compared against the extracted archive.
Default: 1

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is configurable so release manager can turn it off when verifying the local tag before pushing it to the remote

@CTTY

CTTY commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

This will make dev/release/verify_rc.sh 0.10.0 2 fail on the error below:

diff -r git-tag-archive/apache-iceberg-rust-0.10.0/.github/workflows/bindings_python_ci.yml apache-iceberg-rust-0.10.0/.github/workflows/bindings_python_ci.yml
84a85,94
>       # Linux maturin builds may run inside manylinux Docker, so host Rust caches only help Windows/macOS.
>       - name: Setup Rust toolchain
>         if: runner.os != 'Linux'
>         uses: ./.github/actions/setup-builder
>       - name: Cache Rust artifacts
>         if: runner.os != 'Linux'
>         uses: swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
>         with:
>           key: bindings-python
>           save-if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
diff -r git-tag-archive/apache-iceberg-rust-0.10.0/CHANGELOG.md apache-iceberg-rust-0.10.0/CHANGELOG.md
266a267,268
> * chore: Update changelog and dependency lists for 0.10.0 by @dannycjones in https://github.com/apache/iceberg-rust/pull/2745
> * chore(ci): Remove '--locked' flag on toml-cli install by @dannycjones in https://github.com/apache/iceberg-rust/pull/2750
Source archive does not match git tag v0.10.0-rc.2.
FAILED: Verify source archive matches git tag v0.10.0-rc.2
Failed to verify release candidate. See /var/folders/3r/b8hzqplj4y1dtv735y6rps5c0000gq/T/iceberg-rust-0.10.0-rc2.XXXXXX.JkIjwCLRJy for details.

@CTTY CTTY marked this pull request as ready for review July 3, 2026 06:15
Comment thread dev/release/verify_rc.sh Outdated

@blackmwk blackmwk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CTTY for this pr!

@blackmwk blackmwk merged commit d3de068 into apache:main Jul 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants