ci: drop unnecessary protoc installs#2805
Merged
laskoviymishka merged 1 commit intoJul 11, 2026
Merged
Conversation
laskoviymishka
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Deletes every
Install protocstep: five in ci.yml, one in public-api.yml, one in website.yml.The installs were added with the datafusion 48 bump (#1501). That bump pulled in the
substraitcrate, whose build script runs prost-build, and prost-build shells out to protoc. The DataFusion 54 bump (#2648) droppedsubstraitandprost-buildfrom the tree, and prost-build was the only thing that ever ran protoc. The remainingprost/prost-derivedependencies come from datafusion-proto, which ships pregenerated code and has no build script. So nothing inmake build, the test suite, or thecargo docrun in website.yml needs protoc anymore.A side benefit of this simplification is that we remove a dependency on arduino/setup-protoc, which hasn't seen a commit since September 2024 and was printing a Node runtime deprecation warning on every run.
Are these changes tested?
cargo metadataconfirms datafusion-proto and datafusion-proto-common have no build script.prost-buildis absent from Cargo.lock and nothing in the workspace source references protoc.