IGNITE-24364 Store zone-wide tx state storage per zone #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpwc
reviewed
Feb 5, 2025
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java
Show resolved
Hide resolved
...ator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java
Show resolved
Hide resolved
...ator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java
Outdated
Show resolved
Hide resolved
...ator/src/main/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManager.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/ignite/internal/partition/replicator/ZoneResourcesManagerTest.java
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java
Outdated
Show resolved
Hide resolved
sanpwc
reviewed
Feb 6, 2025
| @@ -521,6 +541,16 @@ private CompletableFuture<?> createZonePartitionReplicationNode( | |||
| }); | |||
| } | |||
|
|
|||
| private CatalogZoneDescriptor zoneDescriptorAt(int zoneId, long timestamp) { | |||
sanpwc
reviewed
Feb 6, 2025
| @@ -413,6 +423,8 @@ private CompletableFuture<Void> calculateZoneAssignmentsAndCreateReplicationNode | |||
| return inBusyLockAsync(busyLock, () -> { | |||
| int zoneId = zoneDescriptor.id(); | |||
|
|
|||
| zoneResourcesManager.registerZonePartitionCount(zoneId, zoneDescriptor.partitions()); | |||
There was a problem hiding this comment.
I don't like such approach.
What about using
catalogMgr.activeCatalog(metaStorageMgr.timestampByRevisionLocally(revision).longValue()).zone(zonePartitionId.zoneId()).partitions(); in order to retrieve partitions count in PartitionReplicaLifecycleManager#createZonePartitionReplicationNode and thus propagating the count to ZoneResourcesManager#getOrCreatePartitionTxStateStorage
?
There was a problem hiding this comment.
- The timestamp on MS entry for a catalog update is not the same as activation timestamp of the catalog update
- This seems really fragile
- We could probably get into trouble with MS compaction
Current approach is simple and solves the task at hand. Also, it doesn't introduce races. Why don't you like it?
There was a problem hiding this comment.
I changed the approach: registration is removed
sanpwc
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24364