New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-22621 Implement transaction storage for the zone replica listener #5187

Merged

rpuch merged 28 commits into apache:main from gridgain:ignite-22621

Feb 11, 2025

Contributor

rpuch commented Feb 6, 2025

https://issues.apache.org/jira/browse/IGNITE-22621

rpuch marked this pull request as draft

February 7, 2025 06:34

rpuch force-pushed the ignite-22621 branch 6 times, most recently from 824c6ac to fd09468 Compare

February 7, 2025 11:56


          IGNITE-22621 Implement transaction finishing for zone replica listener

12237bb

rpuch force-pushed the ignite-22621 branch from fd09468 to 12237bb Compare

February 7, 2025 12:24

rpuch marked this pull request as ready for review

February 7, 2025 12:24

sanpwc reviewed

View reviewed changes

...rc/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...rc/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

.../src/integrationTest/java/org/apache/ignite/internal/partition/replicator/fixtures/Node.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...tor/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaListenerHelper.java Outdated Show resolved Hide resolved

rpuch added 7 commits

February 10, 2025 11:01


          IGNITE-22621 / remove duplicate CatalogService parameter

c3747a5


          IGNITE-22621 / make a field private

adce99f


          IGNITE-22621 / rename fields and parameters

a99e3d4


          IGNITE-22621 / rename a method

c74cbd6


          IGNITE-22621 / remove a blank line

1c1b9fb


          Merge branch 'main' into ignite-22621

479d316


          IGNITE-22621 / split a helper; rename other helpers

0a554d1

sk0x50 reviewed

View reviewed changes

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved

rpuch added 3 commits

February 10, 2025 14:06


          IGNITE-22621 / add a TODO

4b80593


          IGNITE-22621 / fix checkstyle violations

39181e0


          IGNITE-22621 / unlock after tx is finished

fa03b6f

sanpwc reviewed

View reviewed changes

...r/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...licator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...licator/src/main/java/org/apache/ignite/internal/partition/replicator/ReplicaTxFinisher.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java Outdated Show resolved Hide resolved

sanpwc reviewed

View reviewed changes

...main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java Show resolved Hide resolved

rpuch added 2 commits

February 10, 2025 17:35


          IGNITE-22621 / rename a method

452f0e9


          IGNITE-22621 / rename classes

57a43b1

sashapolo reviewed

View reviewed changes

...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java Show resolved Hide resolved

...-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/ResultWrapper.java Outdated Show resolved Hide resolved

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved

...ain/java/org/apache/ignite/internal/partition/replicator/raft/ZonePartitionRaftListener.java Show resolved Hide resolved

...main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java Outdated Show resolved Hide resolved

...main/java/org/apache/ignite/internal/partition/replicator/TxFinishReplicaRequestHandler.java Outdated Show resolved Hide resolved

...tionTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java Outdated Show resolved Hide resolved

...tionTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java Show resolved Hide resolved

...tionTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java Outdated Show resolved Hide resolved

sanpwc approved these changes

View reviewed changes

rpuch added 10 commits

February 11, 2025 10:35


          IGNITE-22621 / update javadoc

b313c61


          IGNITE-22621 / remove supplier

af1e4f8


          IGNITE-22621 / remove ResultWrapper

ac9ff71


          IGNITE-22621 / use capacity()

dd0f9ef


          IGNITE-22621 / improve javadoc

309f365


          IGNITE-22621 / improve a comment

d1d6c27


          IGNITE-22621 / add @nullable

25c49e4


          IGNITE-22621 / improve indentation

fd6527f


          IGNITE-22621 / remove unwrapping

59367d8


          IGNITE-22621 / remove CountExpectation

bfe996a

sashapolo reviewed

View reviewed changes

...tionTest/java/org/apache/ignite/internal/partition/replicator/ItZoneDataReplicationTest.java

                           ));
                       }
-                      List<CountExpectation> expectations = new ArrayList<>();
+                      List<Executable> assertions = new ArrayList<>();
                       for (int i = 0; i < cluster.size(); i++) {

Contributor

sashapolo Feb 11, 2025

You can use IntStream.range().collect(toList()) here instead of a cycle, this will save some code, like finalI. Current approach is also fine.

...r/src/main/java/org/apache/ignite/internal/partition/replicator/ReliableCatalogVersions.java Outdated Show resolved Hide resolved

sashapolo approved these changes

View reviewed changes


          Merge branch 'main' into ignite-22621

05d3254

sashapolo reviewed

View reviewed changes

...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java

                               rebalanceRetryDelayConfiguration
                       );
+                      var safeTimeTracker = new SafeTimeValuesTracker(HybridTimestamp.MIN_VALUE);

Contributor

sashapolo Feb 11, 2025

Shall we move all this stuff inside the Supplier as well?

Contributor Author

rpuch Feb 11, 2025

Why?

Contributor

sashapolo Feb 11, 2025

Why not? Its only used inside it

sashapolo reviewed

View reviewed changes

...n/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java Show resolved Hide resolved

rpuch added 3 commits

February 11, 2025 12:58


          IGNITE-22621 / add a blank line

24e67df


          IGNITE-22621 / improve javadoc

5e9f947


          IGNITE-22621 / fix checkstyle violations

da7c052

sashapolo approved these changes

View reviewed changes

rpuch merged commit 9e3d7c4 into apache:main

1 check passed

rpuch deleted the ignite-22621 branch

February 11, 2025 10:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet