-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGNITE-24359 Adjust ScanCloseReplicaRequest to be TableAware one #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk0x50
reviewed
Feb 11, 2025
...grationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java
Show resolved
Hide resolved
sk0x50
reviewed
Feb 11, 2025
...c/main/java/org/apache/ignite/internal/table/distributed/storage/PartitionScanPublisher.java
Show resolved
Hide resolved
Could you please also adjust ScanCloseReplicaRequest building in PartitionReplicaListenerTest? |
Done |
sk0x50
approved these changes
Feb 11, 2025
sanpwc
approved these changes
Feb 11, 2025
# Conflicts: # modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/PartitionReplicaListenerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-24359
The goal
The main goal of the ticket is to extend
ScanCloseReplicaRequest
with additional oneTableAware
interface.The reason
We want to work with
ScanCloseReplicaRequest
throughZonePartitionId
, but for proper table state machine selection we have to carry a table's identifier too.The solution
The solution is straightforward:
ScanCloseReplicaRequest
now extendsTableAware
.InternalTableImpl#completeScan
we passZonePartitionId
if the colocation feature flag is enabled andTablePartitionId
otherwise.tableId
through new methods.testScanCloseReplicaRequest
: the test creates a node, a zone and a table, inserts several rows and then starts scan with explicit transaction that will be cancelled in the end and triggersInternalTableImpl#completeScan
withexplicitCloseCursor == true
.